Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision of #531 #598

Merged
merged 9 commits into from
Jan 30, 2016
Merged

Revision of #531 #598

merged 9 commits into from
Jan 30, 2016

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jan 30, 2016

This pull request

@jslee02 jslee02 added this to the DART 6.0.0 milestone Jan 30, 2016
@jslee02
Copy link
Member Author

jslee02 commented Jan 30, 2016

A bug of VS2015 was reported pertain to constexpr with functions pointer (see bug 1378031). The blog post says it's fixed, but it seems not at least for our case. Here is the error message:

[00:00:50] C:\projects\dart\dart/dynamics/Addon.h(63): error C2131: expression did not evaluate to a constant (compiling source file C:\projects\dart\dart\dynamics\BallJoint.cpp) [C:\projects\dart\build\dart\dart-core.vcxproj]

@mxgrey
Copy link
Member

mxgrey commented Jan 30, 2016

Is it possible that Appveyor doesn't have the latest updates for VS2015? Or have we found an extra-special case of the constexpr bug?

@jslee02
Copy link
Member Author

jslee02 commented Jan 30, 2016

The compilation errors are occurring with my VS2015, which is the most recent version with Update 1 (14.0.2478.2), as well. AppVeyor's one is 14.0.24720.0.

I can't say it's a VS2015 bug definitely, but it seems so for now.

@jslee02
Copy link
Member Author

jslee02 commented Jan 30, 2016

Merging even VS2015 can't build this.

jslee02 added a commit that referenced this pull request Jan 30, 2016
@jslee02 jslee02 merged commit 7b7a4b1 into grey/addons Jan 30, 2016
@jslee02 jslee02 deleted the grey/addons_js_revision branch January 31, 2016 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants